Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(art-gallery-example): wait for images to be loaded #32802

Merged
merged 6 commits into from
Jul 11, 2024
Merged

fix(art-gallery-example): wait for images to be loaded #32802

merged 6 commits into from
Jul 11, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 22, 2024 •
edited
Loading

Description

Draw images only when they're all loaded.

Motivation

The images aren't always loaded yet when they are drawn on the canvas.

Additional details

Related issues and pull requests

Fixes #30782.
@caugner caugner requested a review from a team as a code owner March 22, 2024 16:08
@caugner caugner requested review from sideshowbarker and removed request for a team March 22, 2024 16:08
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Mar 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-07-08 14:11:52)
@caugner caugner marked this pull request as draft March 22, 2024 16:11
@caugner caugner changed the title fix(canvas): draw gallery when loaded Mar 22, 2024
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Mar 22, 2024
@bsmth bsmth self-assigned this Jun 27, 2024
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jun 27, 2024
@bsmth
Copy link
Member

bsmth commented Jun 27, 2024

@caugner can you check 3d8a8bf to let me know if it looks okay?
@sideshowbarker sideshowbarker removed their request for review June 28, 2024 03:13
@caugner
Copy link
Contributor Author

caugner commented Jul 8, 2024

@caugner can you check 3d8a8bf to let me know if it looks okay?

@bsmth Thank you for taking over, looking good to me on the preview! 🙌
@bsmth bsmth marked this pull request as ready for review July 8, 2024 14:09
bsmth
bsmth approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving a +1 for @caugner's changes. Would be good to have a quick look from someone else, but I think we're good to go in general!
@bsmth
Copy link
Member

bsmth commented Jul 11, 2024

I'm going to merge because I mostly updated prose so let's get it in!
@bsmth bsmth merged commit 0cd6815 into main Jul 11, 2024
9 checks passed
@bsmth bsmth deleted the caugner-patch-1 branch July 11, 2024 08:42
evelinabe pushed a commit to evelinabe/mdn-content that referenced this pull request Jul 12, 2024
@caugner @bsmth @evelinabe
fix(art-gallery-example): wait for images to be loaded (mdn#32802)
90e84cc 
* fix(art-gallery-example): wait for all images to be loaded

* fix(api): Use Promise.all on other examples with multiple images

---------

Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
2 participants
@caugner @bsmth