Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the note about aria-owns not being supported in Safari on iOS and macOS #32593

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

PeterSaathoff-Harshfield
Copy link
Contributor

@PeterSaathoff-Harshfield PeterSaathoff-Harshfield commented Mar 6, 2024

Removing the note about aria-owns not being supported in Safari on iOS and macOS because it is now supported. See accessibilitysupported/a11ysupport.io#281 for more info.

Description

Removing a note about aria-owns not being supported on iOS and macOS because it is now supported. I tested with iOS and macOS VoiceOver using multiple web pages.

Motivation

This note is out of date.

Additional details

accessibilitysupported/a11ysupport.io#281
https://mastodon.social/@pesh/112045384811778674

Related issues and pull requests

Fix #33436

…S and macOS

Removing the note about aria-owns not being supported in Safari on iOS and macOS because it is now supported. See accessibilitysupported/a11ysupport.io#281 for more info.
@PeterSaathoff-Harshfield PeterSaathoff-Harshfield requested a review from a team as a code owner March 6, 2024 23:20
@PeterSaathoff-Harshfield PeterSaathoff-Harshfield requested review from scottaohara and removed request for a team March 6, 2024 23:20
@github-actions github-actions bot added Content:Accessibility Accessibility docs size/xs [PR only] 0-5 LoC changed labels Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-owns
Title: aria-owns

(comment last updated: 2024-07-09 20:28:25)

@@ -42,8 +42,6 @@ The {{CSSXRef('order')}} property, part of flex or grid layouts, can be used to

Make sure your owned elements have only one owner. Do not specify the `id` of an element in more than one other element's `aria-owns` attribute. An element can have only one owner.

> **Warning:** At the time of this writing, [`aria-owns` is not supported](https://a11ysupport.io/tech/aria/aria-owns_attribute) on MacOS and iOS with VoiceOver.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think it's a good idea to remove the warning all together, as that doesn't acknowledge the fact there would still be an "issue" for people who were using / need to support versions of Safari prior to the release this change went out in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing this to the following when a11ysupport.io confirms safari support:

Suggested change
> **Warning:** At the time of this writing, [`aria-owns` is not supported](https://a11ysupport.io/tech/aria/aria-owns_attribute) on MacOS and iOS with VoiceOver.
> **Warning:** While [`aria-owns` is now supported](https://a11ysupport.io/tech/aria/aria-owns_attribute) in all modern browsers, `aria-owns` is not exposed to users of MacOS and iOS using VoiceOver prior to version X.

where X is the version listed on https://a11ysupport.io/tech/aria/aria-owns_attribute

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this suggestion. a11ysupport.io now shows iOS/macOS being supported, but I don't see any version numbers referenced there, and I also didn't notice exactly which version made the change. All I know is, it was somewhere between iOS 16.0/macOS 13.0 and iOS 17.3/macOS 14.3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support was added around feb 2024 (right before this issue was filed / a11ysupport was updated)

i'm sure a quick google search will help determine what version number was released around that time.

@bsmth bsmth added the awaiting response Awaiting for author to address review/feedback label Apr 9, 2024
@bsmth
Copy link
Member

bsmth commented Jun 13, 2024

Hi @PeterSaathoff-Harshfield - thanks a lot for the suggestions. There's some review comments outstanding for you to take a look at. Do you plan to come back to this one? Thank you! :)

@PeterSaathoff-Harshfield
Copy link
Contributor Author

Sorry, I'm very unfamiliar with how to do this and don't want to make a mistake. I commented above because the suggestion by estelle included a version number but we unfortunately don't know the exact version it changed.

@@ -44,8 +44,6 @@ The {{CSSXRef('order')}} property, part of flex or grid layouts, can be used to

Make sure your owned elements have only one owner. Do not specify the `id` of an element in more than one other element's `aria-owns` attribute. An element can have only one owner.

> **Warning:** At the time of this writing, [`aria-owns` is not supported](https://a11ysupport.io/tech/aria/aria-owns_attribute) on MacOS and iOS with VoiceOver.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Suggested change
> **Warning:** At the time of this writing, [`aria-owns` is not supported](https://a11ysupport.io/tech/aria/aria-owns_attribute) on MacOS and iOS with VoiceOver.
> **Warning:** While [`aria-owns` is now supported](https://a11ysupport.io/tech/aria/aria-owns_attribute) in all modern browsers, `aria-owns` may not be exposed to users of MacOS and iOS using VoiceOver prior to iOS 17.3 and macOS 14.3.

by adding "may" we don't need to be exact, but are enabling this to be edited out in the future when both of those versions are almost obsolete.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterSaathoff-Harshfield Let me know you're ok with this suggestion by merging. Or, feel free to edit.

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@estelle estelle merged commit b43e855 into mdn:main Jul 9, 2024
8 checks passed
evelinabe pushed a commit to evelinabe/mdn-content that referenced this pull request Jul 12, 2024
…S and macOS (mdn#32593)

* Removing the note about aria-owns not being supported in Safari on iOS and macOS

Removing the note about aria-owns not being supported in Safari on iOS and macOS because it is now supported. See accessibilitysupported/a11ysupport.io#281 for more info.

* Update files/en-us/web/accessibility/aria/attributes/aria-owns/index.md

---------

Co-authored-by: Estelle Weyl <estelle@weyl.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Awaiting for author to address review/feedback Content:Accessibility Accessibility docs size/xs [PR only] 0-5 LoC changed
4 participants