Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation for HTMLMapElement.areas #31713

Merged
merged 29 commits into from
Jul 13, 2024

Conversation

ShubhamOulkar
Copy link
Contributor

@ShubhamOulkar ShubhamOulkar commented Jan 14, 2024

Description

adding new documentation for HTMLMapElement.areas

It is part of mdn/mdn#520

Resource

areas property

@ShubhamOulkar ShubhamOulkar requested a review from a team as a code owner January 14, 2024 10:52
@ShubhamOulkar ShubhamOulkar requested review from sideshowbarker and removed request for a team January 14, 2024 10:52
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jan 14, 2024
files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
ShubhamOulkar and others added 6 commits January 14, 2024 16:24
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jan 14, 2024

Preview URLs

(comment last updated: 2024-07-13 06:21:49)

Copy link
Contributor Author

@ShubhamOulkar ShubhamOulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor correction in content

files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/htmlmapelement/areas/index.md Outdated Show resolved Hide resolved
ShubhamOulkar and others added 3 commits January 15, 2024 17:05
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ShubhamOulkar and others added 2 commits January 16, 2024 06:42
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the size/l [PR only] 501-1000 LoC changed label Jan 21, 2024
@teoli2003
Copy link
Member

Is this ready for re-review? Asking because the live sample is not working: https://pr31713.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/HTMLMapElement/areas

Anything I can do to help?

@ShubhamOulkar
Copy link
Contributor Author

ShubhamOulkar commented Jan 24, 2024

Anything I can do to help?

Thank you for reporting @teoli2003.

Yes, help me out. Local server shows the image. I don't know what is happening with preview URL.

image

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/l [PR only] 501-1000 LoC changed labels May 7, 2024
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the example with something that better represents the usage of areas. I have verified that the live example works locally. Since this has been open for so long, I won't delay it further. Thanks for the work!

@Josh-Cena Josh-Cena merged commit da6219d into mdn:main Jul 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
5 participants