Add HTMLBaseElement.href docs #31464
Conversation
|
Preview URLs (comment last updated: 2024-07-12 00:52:24) |
Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>
|
|
||
| {{APIRef("HTML DOM")}} | ||
|
|
||
| The **`href`** property of the {{domxref("HTMLBaseElement")}} interface contains a string that is the URL to use as the base for relative URLs, like links pointing to a fragment in the document (`<a href="#example">`). |
There was a problem hiding this comment.
I don't like "like" here, because it tends to be an ambiguous word. "such as" would be better. But I'm not sure whether we need this clause at all. Better would be to make "relative links" link to a proper explanation: https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Creating_hyperlinks#absolute_versus_relative_urls might do, although I wonder if this would be a suitable glossary topic, or if we could extend https://developer.mozilla.org/en-US/docs/Glossary/URL to cover it.
| ```js | ||
| const base = document.getElementsByTag("base")[0]; | ||
| console.log(base.href); // 'https://developer.mozilla.org/example' | ||
| ``` |
There was a problem hiding this comment.
Should we also show the result if there is no href attribute?
There was a problem hiding this comment.
there can only be one base element in a page, so we can't include two in a single example; opting to not include and target-only <base> example.
There was a problem hiding this comment.
We could have two examples. I'd have done that, except that this violates CSP and I get an error for that case.
There was a problem hiding this comment.
But I think is OK without both. The expected behaviour is stated.
wbamberg
added
the
awaiting response
Co-authored-by: wbamberg <will@bootbonnet.ca>
Co-authored-by: wbamberg <will@bootbonnet.ca>
| ```js | ||
| const base = document.getElementsByTag("base")[0]; | ||
| console.log(base.href); // 'https://developer.mozilla.org/example' | ||
| ``` |
There was a problem hiding this comment.
there can only be one base element in a page, so we can't include two in a single example; opting to not include and target-only <base> example.
|
@wbamberg when you have a chance, a re-review would be great. |
github-actions
bot
added
size/m
* Add HTMLBaseElement.href docs * Update files/en-us/web/api/htmlbaseelement/href/index.md Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com> * Update files/en-us/web/api/htmlbaseelement/href/index.md * Update files/en-us/web/api/htmlbaseelement/href/index.md Co-authored-by: wbamberg <will@bootbonnet.ca> * Update files/en-us/web/api/htmlbaseelement/href/index.md Co-authored-by: wbamberg <will@bootbonnet.ca> * Apply suggestions from code review * Apply suggestions from code review * Make example into live example * Update files/en-us/web/api/htmlbaseelement/href/index.md --------- Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com> Co-authored-by: Estelle Weyl <estelle@weyl.org> Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> Co-authored-by: wbamberg <will@bootbonnet.ca> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
This adds the missing
HTMLBaseElement.hrefpage.Part of the project to document all interoperable features (mdn/discussions#476)