Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native messaging code example update #29104

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Sep 14, 2023

Description

Addresses improvement feedback.

Related issues and pull requests

Fixes #2059

@rebloor rebloor added the Content:WebExt WebExtensions docs label Sep 14, 2023
@rebloor rebloor requested a review from zombie September 14, 2023 03:47
@rebloor rebloor self-assigned this Sep 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Preview URLs

(comment last updated: 2023-09-14 03:52:07)

@rebloor
Copy link
Contributor Author

rebloor commented Sep 14, 2023

@zombie I have an outstanding issue that I can't make the nativeMessaging example work (fails to get the "pong" with a message that the port was closed). If you are able to confirm the change should work as expected, let me know and I'll move out of draft. Otherwise, I'll leave as draft until I can test.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Nov 23, 2023
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs merge conflicts 🚧 [PR only]
1 participant