Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): update at-rule page #34709

Merged
merged 5 commits into from
Jul 11, 2024
Merged

fix(css): update at-rule page #34709

merged 5 commits into from
Jul 11, 2024

Conversation

OnkarRuikar
Copy link
Contributor

The PR restructures the page as per the specification at-rule section .
The new classification is based on at-rule usage.
@OnkarRuikar OnkarRuikar requested a review from a team as a code owner July 8, 2024 09:30
@OnkarRuikar OnkarRuikar requested review from estelle and removed request for a team July 8, 2024 09:30
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

Preview URLs (9 pages)
Flaws (1)

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_conditional_rules
Title: CSS conditional rules
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

(comment last updated: 2024-07-11 04:49:57)
estelle
estelle reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about it at the meeting.
files/en-us/web/css/at-rule/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/at-rule/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/at-rule/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/at-rule/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/at-rule/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/at-rule/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/at-rule/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_conditional_rules/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_syntax/error_handling/index.md Outdated Show resolved Hide resolved
@OnkarRuikar @estelle
Apply suggestions from code review
4fe516c 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@OnkarRuikar OnkarRuikar marked this pull request as draft July 9, 2024 06:41
@OnkarRuikar OnkarRuikar marked this pull request as ready for review July 9, 2024 09:19
estelle
estelle reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new DL looks so much better than the original. Thank you!

let's get rid of the "use case" area that divides them by use case.

In a future PR, we should add all the missing at-rules and see if we can make the left sidebar have the at-rule section expanded. But that is not this PR. For this PR, we can get rid of the 3rd list to improve the page.
files/en-us/web/css/at-rule/index.md Outdated
- {{cssxref("@supports")}}
- : A conditional group rule that will apply its content if the browser meets the criteria of the given condition.

## At-rule uses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's eliminate this entire section. The page has two other lists of at-rules. This third list may be more confusing than helpful for some.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
There is no official classification of at-rules in the specs, so we don't have to come up with one forcefully.
@OnkarRuikar OnkarRuikar requested a review from estelle July 11, 2024 04:52
estelle
estelle approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉
@estelle estelle merged commit bf601f2 into mdn:main Jul 11, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_atrules branch July 11, 2024 04:59
evelinabe pushed a commit to evelinabe/mdn-content that referenced this pull request Jul 12, 2024
@OnkarRuikar @estelle @evelinabe
fix(css): update at-rule page (mdn#34709)
446363d 
* fix(css): update at-rule page

* Apply suggestions from code review

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

* address remaining review comments

* remove usage section

---------

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
2 participants
@OnkarRuikar @estelle