-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thresholds to each request #2785
base: master
Are you sure you want to change the base?
Add thresholds to each request #2785
Conversation
Hi! I do see the point in having this, but complicating HttpSession in for what is kind of a rare case doesnt make sense, it needs to be a subclass or something (side note: what are those print statements about? :) |
I think a subclass would make sense, yeah, this is just a draft, whenever the PR is ready for review I'll remove the print statements! :) Kk, I'll work on that and @ you whenever it's ready! |
This reverts commit 48afd55.
@cyberw I've added a new HttpSession subclass for this, and to use this there is a new HttpUser, if you think this can or should be done differently let me know! |
This PR adds an argument to each request to add a threshold to it, if a request response time is over the threshold it'll be logged
This also adds a new stat in the webui (the threshold) that's hidden if there are no thresholds defined.
Images
Related issue: #2668
I want to know if @cyberw thinks this can be added to the core (and it's being done nicely) before I resume my work on it!