Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL Directory, and Multi-File Support for File Distribution #2766

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

URL Directory, and Multi-File Support for File Distribution #2766

wants to merge 9 commits into from

Conversation

andrewbaldwin44
Copy link
Collaborator

Proposal

  1. Move some functions to utility files to permit re-usability and to help simplify the argument parser file
  2. Update the logic for master sending locustfiles to the workers so that it can support URLs, directories, and multi-files
  3. Re-use parse_locustfile_paths for workers receiving file paths from master

Opening as a draft, if this looks good I'll create some tests for it
@cyberw
Copy link
Collaborator

cyberw commented Jun 25, 2024

What do you think @DennisKrone ?
@cyberw
Copy link
Collaborator

cyberw commented Jul 1, 2024 •
edited
Loading

Looks pretty reasonable. Just a few things: parse_locustfile_paths_from_master isnt very descriptive of what it does (actually downloading files for instance). And needs type hints. Its a bit sad that it is a breaking protocol change.
@cyberw
Copy link
Collaborator

cyberw commented Jul 1, 2024 •
edited
Loading

Are you losing the ability to detect changes in the file contents? (_old_file_contents) That would be bad.
@andrewbaldwin44 andrewbaldwin44 force-pushed the feature/url-file-distribution branch 3 times, most recently from b87f8a3 to 627470e Compare July 4, 2024 18:05
@andrewbaldwin44 andrewbaldwin44 marked this pull request as ready for review July 4, 2024 18:06
cyberw
cyberw reviewed Jul 4, 2024
View reviewed changes
locust/argument_parser.py Outdated Show resolved Hide resolved
cyberw
cyberw reviewed Jul 4, 2024
View reviewed changes
locust/env.py Outdated Show resolved Hide resolved
cyberw
cyberw reviewed Jul 4, 2024
View reviewed changes
locust/runners.py Outdated Show resolved Hide resolved
@andrewbaldwin44 andrewbaldwin44 force-pushed the feature/url-file-distribution branch 9 times, most recently from 6d244dd to 45ef36f Compare July 8, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@andrewbaldwin44 @cyberw