Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom tool input number fail #6200

Merged
merged 2 commits into from
Jul 14, 2024
Merged

fix: custom tool input number fail #6200

merged 2 commits into from
Jul 14, 2024

Conversation

guogeer
Copy link
Contributor

@guogeer guogeer commented Jul 11, 2024 •
edited by crazywoola
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fixes #6199

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

number type input a number ok.

  • Test A
  • Test B
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 13, 2024
@crazywoola crazywoola merged commit 4fdcb30 into langgenius:main Jul 14, 2024
5 checks passed
laipz8200 pushed a commit that referenced this pull request Jul 15, 2024
@guogeer @laipz8200
fix: custom tool input number fail (#6200)
48dfd53 
Co-authored-by: jinqi.guo <jinqi.guo@ubtrobot.com>
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Jul 22, 2024
@Scorpion1221
Merge commit 'eabfd84ceb704f8057b4f499578e24c2516250c4'
8c99d5b 
* commit 'eabfd84ceb704f8057b4f499578e24c2516250c4': (147 commits)
  bump to 0.6.14 (langgenius#6294)
  Feat/delete file when clean document (langgenius#5882)
  fix: zhipuai validate error when user's api key not support for chatglm_turbo in  issue langgenius#6289 (langgenius#6290)
  fix: validateColorHex: cannot read properties of undefined (reading 'length') (langgenius#6242)
  6282 i18n add support for Italian (langgenius#6288)
  Update bedrock.yaml (langgenius#6281)
  feat(frontend): workflow import dsl from url (langgenius#6286)
  feat(backend): support import DSL from URL (langgenius#6287)
  Update model provider configuration for Triton Inference Server and X… (langgenius#6274)
  fix: custom tool input number fail (langgenius#6200)
  Feat/add zhipu CogView 3 tool  (langgenius#6210)
  Fix mermaid render (langgenius#6088)
  fix: markdown proc will remove image (langgenius#5855)
  fix: remove the maximum length limit of "paragraph" variable (langgenius#6234)
  Update ernie_bot.py (langgenius#6236)
  fix: model-provider-card-style (langgenius#6246)
  refactor(api): switch to dify_config with Pydantic in controllers and schedule (langgenius#6237)
  Fix/firecrawl parameters issue (langgenius#6213)
  refactor(services/tasks): Swtich to dify_config witch Pydantic  (langgenius#6203)
  fix: differentiate prompts fields based on function_calling_type (langgenius#5880)
  ...

# Conflicts:
#	.github/workflows/build-push.yml
#	api/configs/app_config.py
#	api/configs/feature/__init__.py
#	api/poetry.lock
#	web/app/components/app/configuration/config-var/config-modal/index.tsx
#	web/yarn.lock
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Jul 22, 2024
@Scorpion1221
Merge commit 'eabfd84ceb704f8057b4f499578e24c2516250c4'
ad1b1b8 
* commit 'eabfd84ceb704f8057b4f499578e24c2516250c4': (147 commits)
  bump to 0.6.14 (langgenius#6294)
  Feat/delete file when clean document (langgenius#5882)
  fix: zhipuai validate error when user's api key not support for chatglm_turbo in  issue langgenius#6289 (langgenius#6290)
  fix: validateColorHex: cannot read properties of undefined (reading 'length') (langgenius#6242)
  6282 i18n add support for Italian (langgenius#6288)
  Update bedrock.yaml (langgenius#6281)
  feat(frontend): workflow import dsl from url (langgenius#6286)
  feat(backend): support import DSL from URL (langgenius#6287)
  Update model provider configuration for Triton Inference Server and X… (langgenius#6274)
  fix: custom tool input number fail (langgenius#6200)
  Feat/add zhipu CogView 3 tool  (langgenius#6210)
  Fix mermaid render (langgenius#6088)
  fix: markdown proc will remove image (langgenius#5855)
  fix: remove the maximum length limit of "paragraph" variable (langgenius#6234)
  Update ernie_bot.py (langgenius#6236)
  fix: model-provider-card-style (langgenius#6246)
  refactor(api): switch to dify_config with Pydantic in controllers and schedule (langgenius#6237)
  Fix/firecrawl parameters issue (langgenius#6213)
  refactor(services/tasks): Swtich to dify_config witch Pydantic  (langgenius#6203)
  fix: differentiate prompts fields based on function_calling_type (langgenius#5880)
  ...

# Conflicts:
#	.github/workflows/build-push.yml
#	api/configs/app_config.py
#	api/configs/feature/__init__.py
#	api/poetry.lock
#	web/app/components/app/configuration/config-var/config-modal/index.tsx
#	web/yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
3 participants
@guogeer @laipz8200 @crazywoola