Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In code node, delete used vars failed. #5962

Closed
5 tasks done
aixgeek opened this issue Jul 4, 2024 · 1 comment · May be fixed by #5964
Closed
5 tasks done

In code node, delete used vars failed. #5962

aixgeek opened this issue Jul 4, 2024 · 1 comment · May be fixed by #5964
Labels
🐞 bug Something isn't working

Comments

@aixgeek
Copy link
Contributor

aixgeek commented Jul 4, 2024

Self Checks

  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
  • Please do not modify this template :) and fill in all the required fields.

Dify version

0.6.11

Cloud or Self Hosted

Cloud, Self Hosted (Docker), Self Hosted (Source)

Steps to reproduce

delete used vars in Code node. It will show the confirm dialog. when click confirm, the used var wasn't deleted.
image

✔️ Expected Behavior

When confirmed, the used vars deleted.

❌ Actual Behavior

delete used vars in Code node. It will show the confirm dialog. when click confirm, the used var wasn't deleted.
@dosubot dosubot bot added the 🐞 bug Something isn't working label Jul 4, 2024
@dosubot DosuBot
Copy link

dosubot bot commented Jul 4, 2024

The issue with deleting used variables in the Code node for Dify version 0.6.11 has been addressed in the latest version (v0.6.12-fix1). Specifically, the _extract_variable_selector_to_variable_mapping method was added to the CodeNode class to improve how variables are managed and preserved, which could help resolve the problem with variable deletion [1].

Additionally, the confirmation dialog for variable deletion is implemented using the ConfirmModal component. There are no known issues with this implementation, but the backend handling of the deletion request involves the handleRemoveVariable function from the useOutputVarList hook, which manages the removal of variables from the node's configuration [2][3].

Updating to the latest version should address the issue you're experiencing.

To continue talking to Dosu, mention @dosu.
@aixgeek aixgeek mentioned this issue Jul 4, 2024
Open
12 tasks
@langgenius langgenius locked and limited conversation to collaborators Jul 4, 2024
@crazywoola crazywoola converted this issue into discussion #5966 Jul 4, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
🐞 bug Something isn't working
1 participant
@aixgeek