huff0: Improve 4X decompression speed 5-10% #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significant degradations, abandoned. ``` λ benchcmp before.txt after.txt benchmark old ns/op new ns/op delta BenchmarkDecompress4XNoTable/digits-32 166962 183522 +9.92% BenchmarkDecompress4XNoTable/gettysburg-32 2747 2783 +1.31% BenchmarkDecompress4XNoTable/twain-32 579833 581783 +0.34% BenchmarkDecompress4XNoTable/low-ent.10k-32 56815 65143 +14.66% BenchmarkDecompress4XNoTable/superlow-ent-10k-32 15217 17399 +14.34% BenchmarkDecompress4XNoTable/case1-32 223 215 -3.63% BenchmarkDecompress4XNoTable/case2-32 178 173 -3.03% BenchmarkDecompress4XNoTable/case3-32 186 178 -4.10% BenchmarkDecompress4XNoTable/pngdata.001-32 78199 79470 +1.63% BenchmarkDecompress4XNoTable/normcount2-32 295 280 -5.22% BenchmarkDecompress4XTable/digits-32 169105 186653 +10.38% BenchmarkDecompress4XTable/gettysburg-32 4113 4243 +3.16% BenchmarkDecompress4XTable/twain-32 580482 589091 +1.48% BenchmarkDecompress4XTable/low-ent.10k-32 57488 66318 +15.36% BenchmarkDecompress4XTable/superlow-ent-10k-32 15801 18111 +14.62% BenchmarkDecompress4XTable/case1-32 2060 2062 +0.10% BenchmarkDecompress4XTable/case2-32 2004 2015 +0.55% BenchmarkDecompress4XTable/case3-32 2026 2040 +0.69% BenchmarkDecompress4XTable/pngdata.001-32 81603 83582 +2.43% BenchmarkDecompress4XTable/normcount2-32 1426 1401 -1.75% ```
|
Visit https://dashboard.github.orijtech.com?back=0&pr=437&remote=false&repo=klauspost%2Fcompress to see benchmark details. |
|
Tons of unrelated deltas in benchmark. The related ones are better, though, so not sure what to think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve huffman 4X decompression speed for tablelog <= 8.