fix #8785 #8786
Merged
fix #8785 #8786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hornc
added
the
Module: Import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8785
Previous behaviour was:
openlibrary, oropenlibrary_edition),ignore the
require_marcsetting and any MARC record present and import the metadata from the archive.org item only.This is the lesser quality import option, and is only used as a fallback in the normal case.
I don't see what the value of this "if we already know about it, use lesser quality metadata" case is.
This PR makes the /ia import consistent.
It's most likely that OL will already have the same MARC metadata (OL is probably where archive.org got its metadata from in the first place), but re-importing the same MARC should not cause a double up, and it will take advantage of any improvements to the import process, so it will be a proper re-import from the same source.
This should fix #8785 where due to the different way archive.org combined fields into its
description, OL was getting redundant fields. Now the /ia import path will always prefer the source MARC when it exists.Technical
Testing
Screenshot
Stakeholders
@cdrini
@seabelis
@scottbarnes