Replace cover URL validation with HTML attributes #8759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
reviewed
Jan 25, 2024
cdrini
added
the
On testing.openlibrary.org
cdrini
approved these changes
Jan 25, 2024
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8755
Refactor. Removes unnecessary/outdated js by handling URL validation with the "url" HTML attribute.
Technical
Very straightforward! Just a quick switch-out in the
add.htmlfile and removal of unnecessary url validation js from thecovers.jsfile.One quick note: This issue originally arose because I noticed that the
valfunction was causing a type error (by trying to run.trim()on an empty string), which isn't directly fixed by this adjustment. Happy to add a quick fix for that -- confirming that$(#selector).val()is not an empty string before running.trim()on it -- to this PR or a separate one, but the fix may not be necessary.Testing
Add a CoverSubmitScreenshot
Stakeholders
@cdrini