Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bookshelves_votes table from schema.sql and pg dumps #8616

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Remove bookshelves_votes table from schema.sql and pg dumps #8616

merged 2 commits into from
Dec 14, 2023

Conversation

jimchamp
Copy link
Collaborator

Removes unused bookshelves_votes table.

Technical

PG dump file was generated after dropping the bookshelves_votes table from a newly created Open Library instance.
Commands used:

docker compose exec -uroot db bash
./openlibrary/scripts/dev-instance/create-dev-db-pgdump.sh > /openlibrary/scripts/dev-instance/dev_db.pg_dump

Testing

Screenshot

Stakeholders

@mekarpeles
@jimchamp jimchamp changed the title Remove bookshelves_votes table from schema.sql, pg dumps Dec 12, 2023
cdrini
cdrini approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; no other refs to bookshelves_votes in codebase
@cdrini cdrini self-assigned this Dec 14, 2023
@cdrini cdrini merged commit 92c40aa into internetarchive:master Dec 14, 2023
3 checks passed
@jimchamp jimchamp deleted the rm-bookshelves_votes branch January 31, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@jimchamp @cdrini