Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#88 add facet pattern new version #1760

Closed
wants to merge 15 commits into from
Closed

#88 add facet pattern new version #1760

wants to merge 15 commits into from

Conversation

wangihzyue
Copy link

resolve #88 .
new version.
wangihzyue and others added 15 commits April 22, 2021 23:46
@wangihzyue
iluwatar#1260
edb412c 
realize compose method pattern.
@wangihzyue
update pom
f153421
@wangihzyue
iluwatar#88
f0224a7 
add facet pattern
@wangihzyue
iluwatar#1260
1336a65
@wangihzyue
Merge pull request iluwatar#1 from wangihzyue/master2
5a4806c 
issue1260 change
@wangihzyue
Update AppTest.java
2c544f0
@wangihzyue
Update MethodEqualTest.java
dc7c575
@wangihzyue
resolve code smell
8550cd8
@wangihzyue
iluwatar#1260
ae3ee08
@wangihzyue
iluwatar#1260
e3c0156
@wangihzyue
iluwatar#1260
8592c18
@wangihzyue
Revert "docs: add JackieNim as a contributor (iluwatar#1749)"
5c58523 
This reverts commit 1dd2628
@wangihzyue
Merge remote-tracking branch 'origin/master'
9f0c1f9 
# Conflicts:
#	.all-contributorsrc
#	README.md
#	pom.xml
@wangihzyue
Revert "docs: add JackieNim as a contributor (iluwatar#1749)"
6460d04 
This reverts commit 1dd2628
@wangihzyue
Revert "docs: add JackieNim as a contributor (iluwatar#1749)"
4015487 
This reverts commit 1dd2628
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.2% 80.2% Coverage
0.0% 0.0% Duplication
@wangihzyue
Copy link
Author

The original pr has some problem on conflict. So I create a new pr. The original pr is #1717
@wangihzyue wangihzyue mentioned this pull request May 19, 2021
Closed
@iluwatar
Copy link
Owner

@wangihzyue it's not a good idea to abandon the original pull request just because there's a conflict. Normally you just merge the master branch to your branch and resolve the conflicts. By closing the old pull request we lose all the review work done so far. Can you confirm that you have addressed all the review comments in #1717 in this pull request?
@wangihzyue
Copy link
Author

e, well, I download the final version of my original pull request and copy my part to this new pull request.
@wangihzyue
Copy link
Author

And my original forked repository has been deleted.
@iluwatar
Copy link
Owner

iluwatar commented Jun 4, 2021

Well, you can still see the review comments we gave at #1717. Please verify that you have done all the requested changes and then ask for another review.
@ohbus
Copy link
Contributor

ohbus commented Jun 7, 2021

The original pr has some problem on conflict. So I create a new pr. The original pr is #1717

If you ever face conflicts just discuss with the maintainers of the repository if you find it difficult to resolve them.

Asking for help is always appreciated.
Ask for Help
@iluwatar iluwatar self-assigned this Jun 22, 2021
iluwatar
iluwatar requested changes Oct 9, 2021
View reviewed changes
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflict and I'll review
@wangihzyue
Copy link
Author

OK, I will do it soon.
@iluwatar
Copy link
Owner

The pull request has remained inactive and is about to be closed. Please comment if you're still working on it.
@iluwatar iluwatar added the status: stale issues and pull requests that have not had recent interaction label Sep 21, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Sep 21, 2022
@iluwatar iluwatar closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: stale issues and pull requests that have not had recent interaction status: under review
3 participants
@wangihzyue @iluwatar @ohbus