Skip to content
This repository has been archived by the owner on Mar 17, 2022. It is now read-only.

Adding aditional Content to Email String translation #476

Closed
MELindley opened this issue Nov 26, 2019 · 2 comments
Closed

Adding aditional Content to Email String translation #476

MELindley opened this issue Nov 26, 2019 · 2 comments
Assignees

Comments

@MELindley
Copy link

MELindley commented Nov 26, 2019

Can you reproduce this issue on default Wordpress theme (eg Storefront)?

Yes:
The additional content for emails is not added to string translations

Can you reproduce this issue when all other plugins are disabled except WooCommerce, Polylang and Hyyan WooCommerce Polylang Integration?

Yes

What product versions and settings are you using when this issue occurs?

  • PHP: 7.2
  • WordPress: 5.2.3
  • WooCommerce: 3.7
  • Polylang: free
  • Hyyan WooCommerce Polylang Integration: 1.4.3
  • Browser: All

I have added the additional_content field to the string translation by rewritting

public function registerString($email_type, $sufix = '') 

and adding

if (isset($settings['additional_content' . $sufix])) {
    pll_register_string('woocommerce_' . $email_type . '_additional_content' . $sufix, $settings['additional_content' . $sufix], __('WooCommerce Emails', 'woo-poly-integration'));
} 

after the recipient field

It's a pretty easy fix, let me know if I should submit a pull request to add the feature :)

@Jon007
Copy link
Contributor

Jon007 commented Dec 7, 2019

yes you are correct there are some email related enhancements in recent woo commerce releases which are not yet added to the plugin, you are welcome to submit pull request

@Jon007 Jon007 self-assigned this Jun 29, 2020
@Jon007
Copy link
Contributor

Jon007 commented Jun 29, 2020

I've added this in development and will check in after fixing a few related issues.
It's a complex subject so adding a note on it here: https://github.com/hyyan/woo-poly-integration/wiki/Email-Languages

Jon007 added a commit that referenced this issue Jun 29, 2020
Addresses multiple email issues causing some fields and default values not to be picked up or translated correctly.
@Jon007 Jon007 closed this as completed Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants