Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to clear site build errors by updating dependency versions #72

Merged
merged 1 commit into from
May 24, 2023
Merged

Attempt to clear site build errors by updating dependency versions #72

merged 1 commit into from
May 24, 2023

Conversation

tkphd
Copy link
Member

@tkphd tkphd commented May 24, 2023

No description provided.

@reid-a
Copy link
Member

reid-a commented May 24, 2023

Can you clarify what problem you're solving? It looks like the faraday gem has had a big version jump?

I checked out the branch, and apparently needed to manually update "faraday", which went from 0.17.3. to 1.10.3, which feels like a big jump.

I guess the issue is that the legacy faraday is not retrievable anymore?
ocaisa
ocaisa approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests are happy, I'm happy
@ocaisa ocaisa merged commit c04f2cc into main May 24, 2023
1 check passed
@tkphd tkphd deleted the build-failures branch May 24, 2023 15:05
@tkphd
Copy link
Member Author

tkphd commented May 24, 2023

The daily builds have been failing for a week, raising a patched warning from Faraday

Top level ::CompositeIO is deprecated, require 'multipart/post' and use `Multipart::Post::CompositeReadIO` instead!
Top level ::Parts is deprecated, require 'multipart/post' and use `Multipart::Post::Parts` instead!

... which is a n error on my local build. The dailies died on

error: RPC failed; curl 55 Send failure: Connection reset by peer
send-pack: unexpected disconnect while reading sideband packet
fatal: the remote end hung up unexpectedly

Updating our dependencies appears to resolve things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@tkphd @reid-a @ocaisa