make facebook counter extraction more robust

heiseonline · May 31, 2016 · 8c05b12 · 8c05b12
1 parent 931390d
commit 8c05b12
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/Changes b/Changes
@@ -1,3 +1,6 @@
+3.1  2016-05-31
+  - Made Facebook counter extraction more robust.
+
 3.0  2016-02-09
   - Updated to Mojolicious 6.0.
   - Removed obsolete tests for Twitter API.

diff --git a/lib/Heise/Shariff.pm b/lib/Heise/Shariff.pm
@@ -5,7 +5,7 @@ use Heise::Shariff::Cache;
 use Mojo::Date;
 use Mojo::Loader qw(load_class find_modules);
 
-our $VERSION  = '3.0';
+our $VERSION  = '3.1';
 
 has service_namespaces => sub {['Heise::Shariff::Service']};
 

diff --git a/lib/Heise/Shariff/Service/Facebook.pm b/lib/Heise/Shariff/Service/Facebook.pm
@@ -31,10 +31,10 @@ sub extract_count {
 
     return undef unless $json;
 
-    if (ref $json eq 'ARRAY' && exists $json->[0]->{share_count}) {
+    if (ref $json eq 'ARRAY' && ref($json->[0]) eq 'HASH' && exists $json->[0]->{share_count}) {
         return $json->[0]->{share_count};
     }
-    if (exists $json->{share} && defined($json->{share}->{share_count})) {
+    if (ref $json eq 'HASH' && ref($json->{share}) eq 'HASH' && defined($json->{share}->{share_count})) {
         return $json->{share}->{share_count};
     }
     return undef;