fix share count in case of api error

If an API throws an error, the share count will be omitted in the backend response.
heiseonline · Dec 2, 2014 · 5a2d47b · 5a2d47b
1 parent ec3cd4e
commit 5a2d47b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/Heise/Shariff.pm b/lib/Heise/Shariff.pm
@@ -5,7 +5,7 @@ use Heise::Shariff::Cache;
 use Mojo::Date;
 use Mojo::Loader;
 
-our $VERSION  = '1.08';
+our $VERSION  = '1.09';
 
 has service_namespaces => sub {['Heise::Shariff::Service']};
 
@@ -67,8 +67,10 @@ sub startup {
                 for (my $i = 0; $i < @transactions; $i++) {
                     # warn dumper $transactions[$i]->res;
                     my $service = $services[$i];
-                    $counts{ $service->get_name } =
-                      $service->extract_count($transactions[$i]->res)
+
+                    if (my $value = $service->extract_count($transactions[$i]->res)) {
+                        $counts{ $service->get_name } = $value;
+                    }
                 }
 
                 my $mtime = time;

diff --git a/lib/Heise/Shariff/Service/Facebook.pm b/lib/Heise/Shariff/Service/Facebook.pm
@@ -21,7 +21,7 @@ sub extract_count {
         return $res->json->[0]->{share_count};
     } else {
         warn dumper($res);
-        return 0;
+        return undef;
     }
 }