Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename executeImpl to executeOperation #4045

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Apr 5, 2024

inline much of the original executeOperation
leave out executeRootGroupedFieldSet, will help reduce the diff for #4026

inline much of the original executeOperation
leave out executeRootGroupedFieldSet, will help reduce the diff for graphql#4026
@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Apr 5, 2024
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 54858b7
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66100529f0a94a0008adad61
😎 Deploy Preview https://deploy-preview-4045--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yaacovCR yaacovCR requested review from a team and robrichard April 5, 2024 14:05
Copy link

github-actions bot commented Apr 5, 2024

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM
@yaacovCR yaacovCR merged commit 13f84cd into graphql:main Apr 5, 2024
21 checks passed
@yaacovCR yaacovCR deleted the rename-executeImpl branch April 5, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
3 participants