Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary duplicated fields from defer tests #3885

Merged
merged 1 commit into from
Apr 19, 2023
Merged

remove unnecessary duplicated fields from defer tests #3885

merged 1 commit into from
Apr 19, 2023

Conversation

yaacovCR
Copy link
Contributor

extracted from #3862
@netlify
Copy link

netlify bot commented Apr 18, 2023 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 74c6bd1
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/643ee3f87e5e760008bc793b
😎 Deploy Preview https://deploy-preview-3885--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.
@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM
@yaacovCR
Copy link
Contributor Author

Motivation: these changes may reduce the test diff if we add duplication; in either case, the tests as they are do not require field duplication.
@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Apr 18, 2023
@yaacovCR yaacovCR requested review from robrichard, a team and IvanGoncharov April 18, 2023 18:41
@yaacovCR yaacovCR merged commit 24b9761 into graphql:main Apr 19, 2023
@yaacovCR yaacovCR deleted the remove-unnecessary-duplication branch April 19, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
2 participants
@yaacovCR @robrichard