Add 'Rule' suffix to all validation rules #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
the
PR: breaking change 💥
Long awaited change, see this disscussion: graphql#808 (comment) Technically it's not a breaking change since only stuff exported from `graphql` and `graphql/validation` are part of public API. However, many tools/libraries depended on this "internal" imports to blacklist certain rules so in graphql#2399 I added missing exports so now you can import them like so: ``` import { ExecutableDefinitionsRule } from 'graphql/validation'; ``` Also I backported missing exports to `14.6.0` release. If this change broke your code please try to migrate it as shown above and please feel free to open an issue if you need assistance with migration.
IvanGoncharov
force-pushed
the
pr_branch
branch
from
c44c175
to
2e191d2
Compare
|
For additional context about this long-awaited please see this discussion: #808 (comment) |
Comment on lines
+330
to
+333
| LoneSchemaDefinitionRuleRule, | ||
| UniqueOperationTypesRuleRule, | ||
| UniqueTypeNamesRuleRule, | ||
| UniqueEnumValueNamesRuleRule, |
There was a problem hiding this comment.
@IvanGoncharov I'm worried there may have been a mistake via find and replace here and in other places, can you take another look please?
There was a problem hiding this comment.
@trevor-scheer Thanks a lot for reporting 👍
Fixed it here: #2407
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Jan 28, 2020
…#2402 Big thanks to @trevor-scheer for reporting it here: https://github.com/graphql/graphql-js/pull/2402/files#r371545963
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Jan 28, 2020
…ql#2402 Big thanks to @trevor-scheer for reporting it here: https://github.com/graphql/graphql-js/pull/2402/files#r371545963
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Jan 28, 2020
…ql#2402 Big thanks to @trevor-scheer for reporting it here: https://github.com/graphql/graphql-js/pull/2402/files#r371545963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically it's not a breaking change since only stuff exported from
graphqlandgraphql/validationare part of the public API.However, many tools/libraries depended on this "internal" imports to
blacklist certain rules so in #2399 I added missing exports so now
you can import them like so:
Also, I backported missing exports to the
14.6.0release.If this change broke your code, please try to migrate it as shown above
and please feel free to open an issue if you need assistance with migration.