Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

Removes all the workbox documentation and redirects to the new docs. #9595

Merged
merged 2 commits into from
May 27, 2022

Conversation

malchata
Copy link
Contributor

@malchata malchata commented May 25, 2022

What's changed, or what was fixed?

  • Removes all Workbox content from d.g.c.
  • Redirects /web/tools/workbox/ to the new workbox docs.

Target Live Date: 2022-05-25

  • This has been reviewed and approved by (@jeffposnick, @petele).
  • I have run npm test locally and all tests pass (@malchata).
  • I have added the appropriate type-something label (@jeffposnick, @petele).
  • I've staged the site and manually verified that my content displays correctly (@malchata).

CC: @petele, @jeffposnick

@jeffposnick
Copy link
Contributor

Right now, URLs that point to specific versions of the Workbox JSDocs (not /latest/, but something like https://developers.google.com/web/tools/workbox/reference-docs/v5/module-workbox-build#.generateSW with /v5/ in the URL) will not redirect anywhere.

I believe, based on the last time we discussed this, that the removal of these historical docs is inevitable, since we can't port the JSDoc generation to d.c.c. But does this PR add in redirects for those older versioned docs, so the URLs will at least point somewhere?

@malchata
Copy link
Contributor Author

@jeffposnick, I added redirects for the following URLs:

/web/tools/workbox/reference-docs/v5
/web/tools/workbox/reference-docs/v4
/web/tools/workbox/reference-docs/v3
/web/tools/workbox/reference-docs/v2

Are there any others I missed?

@jeffposnick jeffposnick self-requested a review May 26, 2022 13:50
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petele petele merged commit f703605 into google:main May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants