Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: go DNS resolver fails to connect to local DNS server [1.21 backport] #67933

Closed
gopherbot opened this issue Jun 11, 2024 · 3 comments
Closed

net: go DNS resolver fails to connect to local DNS server [1.21 backport] #67933

gopherbot opened this issue Jun 11, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.21.12

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #67925 to be considered for backport to the next 1.21 minor release.

@gopherbot Please open backport issues.

The Go DNS resolver doesn't work with at least one DNS server that apparently does not handle EDNS0 additional headers correctly. The fix is to add a new GODEBUG setting. Requesting a backport to add the GODEBUG setting to earlier releases.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 11, 2024
@gopherbot gopherbot mentioned this issue Jun 11, 2024
Closed
@gopherbot gopherbot added this to the Go1.21.12 milestone Jun 11, 2024
@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)
@gabyhelp gabyhelp mentioned this issue Jun 11, 2024
Closed
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Jun 12, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 12, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/592235 mentions this issue: [release-branch.go1.21] net: add GODEBUG=netedns0=0 to disable sending EDNS0 header
gopherbot pushed a commit that referenced this issue Jun 12, 2024
@ianlancetaylor @gopherbot
[release-branch.go1.21] net: add GODEBUG=netedns0=0 to disable sendin…
74ac37e 
…g EDNS0 header

It reportedly breaks the DNS server on some modems.

For #6464
For #21160
For #44135
For #51127
For #51153
For #67925
Fixes #67933

Change-Id: I54a11906159f00246d08a54cc8be7327e9ebfd2c
Reviewed-on: https://go-review.googlesource.com/c/go/+/591995
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
(cherry picked from commit ee4a42b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/592235
Commit-Queue: Ian Lance Taylor <iant@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging 74ac37e to release-branch.go1.21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases
3 participants
@prattmic @gopherbot @gabyhelp