Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo/internal/swig,cmd/go,x/build: swig cgo tests incompatible with C++ toolchain on builders [1.21 backport] #67714

Closed
gopherbot opened this issue May 30, 2024 · 3 comments
Closed

cmd/cgo/internal/swig,cmd/go,x/build: swig cgo tests incompatible with C++ toolchain on builders [1.21 backport] #67714

gopherbot opened this issue May 30, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21.12

Comments

@gopherbot
Copy link
Contributor

gopherbot commented May 30, 2024 •
edited by gabyhelp
Loading

@dmitshur requested issue #67698 to be considered for backport to the next 1.21 minor release.

@gopherbot Please consider this for backport, in particular CL 589295 CL 589495 and CL 589296. They apply test-only fixes that are needed to fix builder failures in newly running tests after a builder change.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. labels May 30, 2024
@gopherbot gopherbot mentioned this issue May 30, 2024
Closed
@gopherbot gopherbot modified the milestones: Go1.21.11, Go1.21.12 May 30, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/591378 mentions this issue: [release-branch.go1.21] cmd/cgo/internal/testsanitizers: make the libfuzzer tests all short
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/591377 mentions this issue: [release-branch.go1.21] cmd/cgo/internal/swig: force use of lld for LTO tests on the builders
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Jun 12, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 12, 2024
gopherbot pushed a commit that referenced this issue Jun 24, 2024
@mknyszek @joedian
[release-branch.go1.21] cmd/cgo/internal/swig: force use of lld for L…
537ec6f 
…TO tests on the builders

For whatever reason, on the builders, when using /usr/bin/ld (the
default linker) with -flto we end up with problems. Specifically, the
linker seems to require LLVMgold.so and can't find it. I'm not really
sure why, but what definitely seems to work is forcing use of lld, which
ships with our clang installation on the builders.

Just enforce this on the builders for now; I've actually had very few
problems running this locally (and I think I'm also mixing and matching
linkers and toolchains too...), so it may be related to the version of
clang we're testing with.

For #67698.
For #67714.

Change-Id: I3bfbcd609e7d0fd70e52ac7e2a0817db95664f20
Cq-Include-Trybots: luci.golang.try:go1.21-linux-amd64-clang15,go1.21-linux-386-clang15
Reviewed-on: https://go-review.googlesource.com/c/go/+/589296
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/591377
@gopherbot
Copy link
Contributor Author

Closed by merging 537ec6f to release-branch.go1.21.
gopherbot pushed a commit that referenced this issue Jun 24, 2024
@mknyszek @joedian
[release-branch.go1.21] cmd/cgo/internal/testsanitizers: make the lib…
29d378a 
…fuzzer tests all short

CL 589295 only made one of the two tests short, because the other one
seemed to be passing consistently in short mode. On the builders, it
seems to still fail maybe 30% of the time by taking too long. Disable
these tests in short mode.

This CL was merged with CL 589295 before cherry-picking.

For #67698.
Fixes #67714.

Change-Id: I9fd047f834f7493b608dd1fee5b9b6dfabbea03d
Cq-Include-Trybots: luci.golang.try:go1.21-linux-amd64-clang15,go1.21-linux-386-clang15
Reviewed-on: https://go-review.googlesource.com/c/go/+/589495
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Michael Knyszek <mknyszek@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/591378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
2 participants
@prattmic @gopherbot