Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: TestOpenFileLimit unintentionally runs on non-Unix platforms [1.21 backport] #63994

Closed
gopherbot opened this issue Nov 7, 2023 · 2 comments
Closed

syscall: TestOpenFileLimit unintentionally runs on non-Unix platforms [1.21 backport] #63994

gopherbot opened this issue Nov 7, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21.5

Comments

@gopherbot
Copy link
Contributor

@dmitshur requested issue #63993 to be considered for backport to the next 1.21 minor release.

This is fixed on tip via CL 539435.

@gopherbot Would you please create a backport issue for Go 1.21?
This is a test-only fix needed to fix trybots on the release branch.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. labels Nov 7, 2023
@gopherbot gopherbot mentioned this issue Nov 7, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 7, 2023
@gopherbot gopherbot added this to the Go1.21.5 milestone Nov 7, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/540615 mentions this issue: [release-branch.go1.21] syscall: copy rlimit.go's build constraint to rlimit_test.go
@heschi heschi added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Nov 7, 2023
@gopherbot
Copy link
Contributor Author

Closed by merging 1e91861 to release-branch.go1.21.
gopherbot pushed a commit that referenced this issue Nov 7, 2023
@dmitshur @gopherbot
[release-branch.go1.21] syscall: copy rlimit.go's build constraint to…
1e91861 
… rlimit_test.go

Tests in rlimit_test.go exist to test the behavior of automatically
bumping RLIMIT_NOFILE on Unix implemented in rlimit.go (issue #46279),
with darwin-specific behavior split out into rlimit_darwin.go and
the rest left empty in rlimit_stub.go.

Since the behavior happens only on Unix, it doesn't make sense to test
it on other platforms. Copy rlimit.go's 'unix' build constraint to
rlimit_test.go to accomplish that.

Leave out the simplification of the build constraint in rlimit_stub.go
so that this CL remains a test-only fix.

In particular, this fixes a problem where TestOpenFileLimit was
failing in some environments when testing the wasip1/wasm port.
The RLIMIT_NOFILE bumping behavior isn't implemented there, so
the test was testing the environment and not the Go project.

Updates #46279.
For #61116.
Fixes #63994.

Change-Id: Ic993f9cfc021d4cda4fe3d7fed8e2e180f78a2ca
Cq-Include-Trybots: luci.golang.try:go1.21-wasip1-wasm_wasmtime
Reviewed-on: https://go-review.googlesource.com/c/go/+/539435
Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit b7cbcf0)
Reviewed-on: https://go-review.googlesource.com/c/go/+/540615
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. Testing An issue that has been verified to require only test changes, not just a test failure.
2 participants
@gopherbot @heschi