Implement 'replaces' field in newOrder and draft-ietf-acme-ari-03 CertID changes #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beautifulentropy
force-pushed
the
draft-ietf-acme-ari-02-new-order-replaces
branch
from
4618bf5
to
a22d17e
Compare
beautifulentropy
changed the title
beautifulentropy
changed the title
|
This is expected and has occurred in the two previous ARI PRs that touch renewForDomains. |
ldez
added
enhancement
area/lib
contrib/waiting-for-feedback
area/ari
|
The current failure of the CI is related to a Pebble bug, I fixed the problem inside #2119. |
ldez
force-pushed
the
draft-ietf-acme-ari-02-new-order-replaces
branch
from
e371021
to
79e475e
Compare
beautifulentropy
changed the title
|
@ldez the changes necessary to support this contribution have been deployed at Let's Encrypt. Let me know if you need anything else. |
|
I missed the conflict 😢 |
ldez
force-pushed
the
draft-ietf-acme-ari-02-new-order-replaces
branch
from
373bb82
to
0c6f225
Compare
3 tasks
mholt
reviewed
May 3, 2024
Comment on lines
+94
to
+107
| der, err := asn1.Marshal(leaf.SerialNumber) | ||
| if err != nil { | ||
| return err | ||
| return "", err | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // makeARICertID constructs a certificate identifier as described in draft-ietf-acme-ari-02, section 4.1. | ||
| func makeARICertID(leaf *x509.Certificate) (string, error) { | ||
| if leaf == nil { | ||
| return "", errors.New("leaf certificate is nil") | ||
| // Check if the DER encoded bytes are sufficient (at least 3 bytes: tag, | ||
| // length, and value). | ||
| if len(der) < 3 { | ||
| return "", errors.New("invalid DER encoding of serial number") | ||
| } | ||
|
|
||
| return fmt.Sprintf("%s.%s", | ||
| strings.TrimRight(base64.URLEncoding.EncodeToString(leaf.AuthorityKeyId), "="), | ||
| strings.TrimRight(base64.URLEncoding.EncodeToString(leaf.SerialNumber.Bytes()), "="), | ||
| ), nil | ||
| // Extract only the integer bytes from the DER encoded Serial Number | ||
| // Skipping the first 2 bytes (tag and length). | ||
| serial := base64.RawURLEncoding.EncodeToString(der[2:]) |
There was a problem hiding this comment.
@beautifulentropy Just curious, why the ASN.1 marshaling and byte stripping? In my testing, leaf.SerialNumber.Bytes() yields the same output as the more complex ASN.1 algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datatracker.ietf.org/doc/draft-ietf-acme-ari/
PLEASE NOTE: this MUST NOT be merged until letsencrypt/boulder#7298 is deployed to Production. I'll keep this issue up-to-date.