-
-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CertID format as per draft-ietf-acme-ari-02 #2066
Conversation
I recall this same failure in #1912 which added inital support for ARI:
|
for now, you can ignore the linter about cyclomatic complexity, I will look at the best way to handle that. |
I fixed the problem of cyclomatic complexity. |
Thanks for fixing this @ldez. Just checked our SRE team and support for this portion of draft-ietf-acme-ari-02 has been successfully deployed to both staging and production. |
Maybe you can set the PR as "Ready for review"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: this change is breaking but it's expected of a draft. So we will not create a major version only for this change.
--ari-hash-name
flag, which is no longer necessary with the updated format.--no-bundle
option. Previously, this was not possible as the draft-ietf-acme-ari-01 format required metadata available only in the issuer.ATTENTION: this must NOT be merged and should remain in draft until letsencrypt/boulder#7184 is merged and deployed.
UPDATE: this change has been merged, but it will not be deployed to Production until a few days into the new year. I'll update this issue when that's the case.