fix: handle node api-api error gracefully #9255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
reviewed
Oct 19, 2018
| @@ -243,13 +242,8 @@ module.exports = async (api, args = {}, pluginSource) => | |||
| ) | |||
| }) | |||
| .catch(err => { | |||
There was a problem hiding this comment.
it seems like this catch should be for individidual plugin API call and not for Promise.mapSeries. It makes using pluginName a bit weird there (fact that it needs to be declared early) plus maybe it would allow for easier recovery in develop?
There was a problem hiding this comment.
(and also returning null would actually make sense there)
There was a problem hiding this comment.
ah probably yes, that's a better option 👍
pieh
approved these changes
Oct 22, 2018
|
Thanks! Sorry for the poor formatting I meant to fix it and got pulled away :/ |
jedrichards
pushed a commit
to jedrichards/gatsby
that referenced
this pull request
Nov 1, 2018
I keep getting weird errors and it was because my gatsby-node.js had issues, but the build was continuing assuming there was a `result`
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
I keep getting weird errors and it was because my gatsby-node.js had issues, but the build was continuing assuming there was a `result`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep getting weird errors and it was because my gatsby-node.js had issues, but the build was continuing assuming there was a
result