Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds error message with filename on Markdown error, fixes bug in panicOnBuild #8866

Merged
merged 5 commits into from
Oct 9, 2018
Merged

Adds error message with filename on Markdown error, fixes bug in panicOnBuild #8866

merged 5 commits into from
Oct 9, 2018

Commits on Oct 6, 2018

  1. Fixes bug in panicOnBuild and adds better error handling for markdown

    @mslooten
    mslooten committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    2e6b354 View commit details
    Browse the repository at this point in the history

  2. Removes console.log

    @mslooten
    mslooten committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    749fd3a View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2018

  1. Only shows path in the error if it's a file

    @mslooten
    mslooten committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    d54169a View commit details
    Browse the repository at this point in the history

  2. Moved the word 'file' to the condition 

    Made the word 'file' conditional as well
    @mslooten
    mslooten committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    d76a1c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2018

  1. Shows node.id when absolutePath is not available 

    As discussed in the PR, it might help people to show the node id when no absolutePath is available (e.g. when not using a file to supply the Markdown)
    @mslooten
    mslooten committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    390dc85 View commit details
    Browse the repository at this point in the history