remove modules that is the relative path. #7934
Conversation
|
ah actually i don't think we want to set |
|
some (not a lot) context for this - #7480 - I would be very happy to see this gone, but css modules stuff would probably need to be looked at again |
|
maybe removing entire |
what is the check for that, i use css modules in all my gatsby projects, including ones where i remove this manually and haven't seen a problem. maybe i'm not hitting the edge case? |
|
I've used this very basic reproduction https://github.com/timurc/gatsby-starter-default-css-module-image-test/ which was throwing can't find 'boa.png' ( https://github.com/timurc/gatsby-starter-default-css-module-image-test/blob/master/src/components/style.module.css - and image is sibling file to css module file) |
|
what was also weird about this issue - that only combo of css modules + mini extract plugin was resulting in that - development (so style-loader instead of mini extract plugin) didn't have problem |
|
BAH found the problem, is cssnano, running to early to minimize the styles and "cleaning" the url to a non relative one. fix incoming |
|
OK fixed and minification is now done correctly per the webpack docs |
|
|
||
| const autoprefixer = require(`autoprefixer`) | ||
| const flexbugs = require(`postcss-flexbugs-fixes`) | ||
| const UglifyPlugin = require(`uglifyjs-webpack-plugin`) | ||
| const TerserPlugin = require(`terser-webpack-plugin`) |
There was a problem hiding this comment.
this is a drop-in replacement but maintained unlike uglify-es
| @@ -430,7 +415,7 @@ module.exports = async ( | |||
| // https://github.com/defunctzombie/package-browser-field-spec); setting | |||
| // the target tells webpack which file to include, ie. browser vs main. | |||
| target: stage === `build-html` || stage === `develop-html` ? `node` : `web`, | |||
| profile: stage === `production`, | |||
There was a problem hiding this comment.
i don't think this was ever true? stage can't be production
packages/gatsby/package.json
Outdated
| @@ -112,6 +112,7 @@ | |||
| "socket.io": "^2.0.3", | |||
| "string-similarity": "^1.2.0", | |||
| "style-loader": "^0.21.0", | |||
| "terser-webpack-plugin": "^1.0.2", | |||
| "type-of": "^2.0.1", | |||
| "uglifyjs-webpack-plugin": "^1.2.4", | |||
| @@ -455,7 +440,11 @@ module.exports = async ( | |||
| splitChunks: { | |||
| name: false, | |||
| }, | |||
| minimize: !program.noUglify, | |||
There was a problem hiding this comment.
I think we still need this boolean, right?
https://webpack.js.org/configuration/optimization/#optimization-minimize
There was a problem hiding this comment.
I moved it lower. noUglify here would disable css minimization as well, which isn't what the argument suggests would happen
|
🎉 THANKS YA'LL |
What is this for? It breaks a lot stuff in weird subtle ways. e.g. react-popper requires a file
popper.jsfrom node_modules inPopper.js, this setting causes the import to resolve to itself instead of the other module of a similar name.