fix: babel options #7865
Merged
fix: babel options #7865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't need to disable babelrc lookup now that we are using the babel apis
|
It'll fix it yeah. The issue is it wasn't using the Babel options Gatsby set, but those options were also wrong :P fix a bug to uncover a new one |
pieh
approved these changes
Sep 5, 2018
|
thank you for fixing the snapshots! i did this in the GH editor :P |
|
Can someone tell me, does a .babelrc completely override Gatsby's or does it merge? I've made one with just the decorators plugin and now it won't build. It's complaining about spreads not being supported so I assume it's now ignored Gatsby's initial .babelrc |
|
Same problem as @akoolenbourke |
|
Adding your own will replace the default one yes, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't need to disable babelrc lookup now that we are using the babel apis
Also i accidentally commited this directly to master and then reverted it SORRY (i'm tired)!