Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SASS config here #6355

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Fix SASS config here #6355

merged 1 commit into from
Jul 10, 2018

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Jul 10, 2018

No description provided.

@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit abdcd9f

https://deploy-preview-6355--using-drupal.netlify.com
@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit abdcd9f

https://deploy-preview-6355--gatsbygram.netlify.com
KyleAMathews
KyleAMathews approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias!
@KyleAMathews KyleAMathews merged commit ec431e0 into master Jul 10, 2018
@KyleAMathews KyleAMathews deleted the jquense-patch-1 branch July 10, 2018 02:20
@zaki-arain
Copy link

any idea when this change will be pushed to NPM?
@KyleAMathews
Copy link
Contributor

We publish changes as they're merged so this was published in early July.
@zaki-arain
Copy link

Oh okay. My gatsby build command is telling me that gatsby-plugin-sass is exporting modifyWebpackConfig but this commit shows it using onCreateWebpack so I'm a bit confused. I'm using gatsby-plugin-sass v1.0.26
@KyleAMathews
Copy link
Contributor

This PR was for v2 where the webpack API changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@jquense @gatsbybot @zaki-arain @KyleAMathews