better css modules in SSR #6352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
commented
Jul 9, 2018
| const loaderUtils = require(`loader-utils`) | ||
| const path = require(`path`) | ||
|
|
||
| module.exports = function(content) { |
There was a problem hiding this comment.
this is the key change here removing this
|
Deploy preview for using-drupal ready! Built with commit 2c909c6 |
|
Deploy preview for gatsbygram ready! Built with commit 2c909c6 |
KyleAMathews
reviewed
Jul 9, 2018
| @@ -122,6 +123,8 @@ module.exports = async ({ | |||
|
|
|||
| const babelConfig = await createBabelConfig(program, stage) | |||
|
|
|||
| const isSSR = stage === `build-html` | |||
There was a problem hiding this comment.
do you want to include develop-html here as well?
KyleAMathews
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup doesn't handle a lot of things, like images.