Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rawMarkdownBody to Markdown node #5557

Merged
merged 6 commits into from
Jun 6, 2018
Merged

Add rawMarkdownBody to Markdown node #5557

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d462e06
Add rawMarkdownBody to node.internal
May 26, 2018
5a8f6fa
Update test snapshot
May 26, 2018
4cb7486
Move rawMarkdownBody out of internal
May 27, 2018
d9db324
Merge branch 'master' of https://github.com/gatsbyjs/gatsby into topi…
May 27, 2018
61e9bc3
Re-update snapshot
May 27, 2018
e3bd700
Remove unnecessary declaration
May 27, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add rawMarkdownBody to node.internal
  • Loading branch information
alexluong committed May 26, 2018
commit d462e06affdebb03f738d6d2f3ffbebe910242f8
1 change: 1 addition & 0 deletions packages/gatsby-transformer-remark/src/on-node-create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ module.exports = async function onCreateNode(
internal: {
content,
type: `MarkdownRemark`,
rawMarkdownBody: data.content,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be in internal, it should be property of markdownNode (similar to excerpt)
},
}

Expand Down
1 change: 1 addition & 0 deletions packages/gatsby/src/joi-schemas/joi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const nodeSchema = Joi.object()
fieldOwners: Joi.array(),
content: Joi.string().allow(``),
description: Joi.string(),
rawMarkdownBody: Joi.string(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to change this schema for single plugin - as mentioned in previous comment, move new property out of internal and remove this schema change
}),
})
.unknown()