Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the port to a number if needed, further fixing #524 #526

Merged
merged 2 commits into from
Oct 31, 2016
Merged

Parse the port to a number if needed, further fixing #524 #526

merged 2 commits into from
Oct 31, 2016

Conversation

bkonkle
Copy link
Contributor

@bkonkle bkonkle commented Oct 30, 2016

Solves the "wrong type of arguments with: 8000" error message introduced in v0.12.3.

@KyleAMathews
Copy link
Contributor

Thanks!

@KyleAMathews KyleAMathews merged commit 744f85f into gatsbyjs:master Oct 31, 2016
KyleAMathews pushed a commit that referenced this pull request Nov 1, 2016
* Parse the port to a number if needed, further fixing #524

* Fix the reassignment of program.port
@KyleAMathews
Copy link
Contributor

@bkonkle hey forgot serve-build needs same treatment — could you make a PR to fix up serve-build.js as well?

@jlengstorf
Copy link
Contributor

Hiya @bkonkle! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants