Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsbygram fixes #38486

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

davidlyons
Copy link

@davidlyons davidlyons commented Aug 28, 2023

Description

Found and fixed a few issues in the Gatsbygram example project:

  • Fixed image scraper, query string, username/likes for GraphQL url nodes, and replaced lodash get() with optional chaining.
  • Download avatar image locally with scraper. Instagram profile pic url isn't allowed cross origin.
  • Ran image scraper for the same account. The large number of files changed in this PR is mostly from the scraper images removed / downloaded / changed in the data/images folder. Some newer images are not square, so set modal image to object-fit: contain to prevent squishing. (This is a quick fix, but looks like Instagram only does a "contain" for horizontal / landscape images, and vertical / portrait images affect the width of the modal so there is no letterboxing on the left and right sides of vertical modal images)
  • Refactored modal to use a function component instead of a class component, useStaticQuery instead of <StaticQuery /> ,and prevent space key on modal from scrolling the page down.
  • Fixed modal findCurrentIndex() condition for broken previous and next buttons.
  • Fixed eslint accessibility warnings: changed 'Load More' anchor to button, ignored modal backdrop div with onClick.
  • Updated dependencies including react-icons and ran automigration for Cypress.
  • Updated logo: more simple retro camera icon from react-icons fa6.

Documentation

Gatsby Blog / Gatsbygram Case Study

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer
1 participant