feat: support styled-components v6 enableVendorPrefixes #38457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding both props, the original and new, to ensure backwards compatibility.
gatsbot
bot
added
the
status: triage needed
pieh
reviewed
Aug 22, 2023
| .default(false) | ||
| .default(true) |
There was a problem hiding this comment.
I don't think we want to change default? Just ensure the new prop is used (with inverse of old one value)?
There was a problem hiding this comment.
For me, the idea was to match the default of styled-components.
If you want to keep it false happy to change it back.
There was a problem hiding this comment.
I think flipping default probably make sense (if that's how default changed in styled-components), but we would have to do so in major version bump, and not regular patch or minor bump as this is "breaking change"
psykzz
commented
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the new
enableVendorPrefixKeeps the original disable prefix, to keep backwards compatibility.
Documentation
https://styled-components.com/docs/api#stylesheetmanager
Tests
Related Issues