Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-source-wordpress): Fix apostrophe typos #37486

Merged
merged 3 commits into from
Jan 30, 2023
Merged

chore(gatsby-source-wordpress): Fix apostrophe typos #37486

merged 3 commits into from
Jan 30, 2023

Conversation

robations
Copy link
Contributor

Apostrophe plural/possesive confusion

Description

Spotted and cleaned up a few apostrophe confusion typos.

Documentation

n/a

Related Issues

n/a
@robations
Grammar in plugin-options.md
8236212 
Apostrophe plural/possesive confusion
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 18, 2023
@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation status: awaiting author response Additional information has been requested from the author and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 18, 2023
@LekoArts
Copy link
Contributor

Hi, thanks for the PR!

The file you changed gets automatically created, so you'll actually need to change this file: https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-source-wordpress/src/steps/declare-plugin-options-schema.js

The markdown file then afterwards gets autogenerated correctly when you run the script: https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-source-wordpress/package.json#L90
@LekoArts LekoArts changed the title Apostrophes in plugin-options.md Jan 18, 2023
@LekoArts LekoArts added topic: source-wordpress Related to Gatsby's integration with WordPress topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) labels Jan 18, 2023
@robations
Copy link
Contributor Author

Ha... thanks. Will adjust when I get a spare minute.
@LekoArts LekoArts removed the status: awaiting author response Additional information has been requested from the author label Jan 30, 2023
LekoArts
LekoArts approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
@LekoArts LekoArts merged commit 82e040c into gatsbyjs:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) topic: source-wordpress Related to Gatsby's integration with WordPress type: documentation An issue or pull request for improving or updating Gatsby's documentation
2 participants
@robations @LekoArts