Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): Safely wrap Head with wrapRootElement #37439

Merged
merged 30 commits into from
Jan 26, 2023
Merged

feat(gatsby): Safely wrap Head with wrapRootElement #37439

merged 30 commits into from
Jan 26, 2023

Conversation

marvinjude
Copy link
Contributor

@marvinjude marvinjude commented Jan 11, 2023 •
edited
Loading

Description

Safely wrap Head with wrapRootElement while making sure to eliminate possible UI elements.

Documentation

See #37519

[sc-58176]
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 11, 2023
@marvinjude marvinjude added topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 11, 2023
@marvinjude marvinjude force-pushed the wrap-head-with-wraprootelement branch from dd43a16 to b0ae35e Compare January 19, 2023 17:06
@marvinjude marvinjude force-pushed the wrap-head-with-wraprootelement branch from 93cf69a to 2bb5194 Compare January 19, 2023 19:13
@marvinjude marvinjude marked this pull request as ready for review January 20, 2023 15:27
@marvinjude marvinjude changed the title WIP: feat(gatsby): Safely wrap Head with wrapRootElement Jan 23, 2023
@marvinjude marvinjude mentioned this pull request Jan 23, 2023
Merged
LekoArts
LekoArts suggested changes Jan 24, 2023
View reviewed changes
packages/gatsby/cache-dir/head/utils.js Outdated Show resolved Hide resolved
packages/gatsby/cache-dir/head/utils.js Outdated Show resolved Hide resolved
LekoArts
LekoArts suggested changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failiing E2E tests 👇
@LekoArts LekoArts merged commit ebbebac into master Jan 26, 2023
@LekoArts LekoArts deleted the wrap-head-with-wraprootelement branch January 26, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
3 participants
@marvinjude @pieh @LekoArts