Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Create static file server for e2e tests #36674

Merged
merged 7 commits into from
Sep 23, 2022
Merged

chore: Create static file server for e2e tests #36674

merged 7 commits into from
Sep 23, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Sep 23, 2022 •
edited
Loading

Description

Statically serve assets from static folder on a separate port for e2e tests.

Should fix flakiness caused by files hosted on third-party CDNs for existing tests and allow us to easily add files for future tests.

Documentation

N/A

Related Issues

[sc-56042]
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 23, 2022
@tyhopp tyhopp added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 23, 2022
@tyhopp tyhopp changed the title chore: Use static file server for script e2e tests Sep 23, 2022
@LekoArts LekoArts merged commit 239b822 into master Sep 23, 2022
@LekoArts LekoArts deleted the test/serve-scripts-locally branch September 23, 2022 07:41
@pieh pieh mentioned this pull request Sep 23, 2022
Closed
pieh pushed a commit that referenced this pull request Oct 25, 2022
@tyhopp @pieh
chore: Create static file server for e2e tests (#36674)
d646d6b 
(cherry picked from commit 239b822)
pieh added a commit that referenced this pull request Oct 25, 2022
@pieh @tyhopp
adjust v4 release branch tests (#36881)
36211d1 
* next -> concrete versions in the branch

* chore: Create static file server for e2e tests (#36674)

(cherry picked from commit 239b822)

Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
2 participants
@tyhopp @LekoArts