fix(gatsby): Make runtime error overlay work in non-v8 browsers #36365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tyhopp
added
topic: core
LekoArts
approved these changes
Aug 11, 2022
This was referenced Aug 16, 2022
This was referenced Aug 16, 2022
This was referenced Aug 16, 2022
This was referenced Aug 16, 2022
This was referenced Dec 26, 2022
sunnyzanchi
added a commit
to newrelic/docs-website
that referenced
this pull request
Jan 3, 2023
on `gatsby` 4.19.0, Firefox won't render the site in development if there are any runtime errors. this was fixed in 4.21.0. see gatsbyjs/gatsby#36365
sunnyzanchi
added a commit
to newrelic/docs-website
that referenced
this pull request
Jan 3, 2023
* fix: upgrade `gatsby` to 4.21.0 to fix Firefox dev on `gatsby` 4.19.0, Firefox won't render the site in development if there are any runtime errors. this was fixed in 4.21.0. see gatsbyjs/gatsby#36365 * upgrade Gatsby core dependencies to 4.21.0
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently use the stack-trace module for error parsing during
gatsby develop. It is meant for use in Node.js environments, so it doesn't work in Safari and Firefox.This PR makes a change to use the error-stack-parser, which has pretty much the same API and handles differences in browser
Errorobjects.Our existing e2e tests didn't catch this because we only test in Chrome. I'm opting not to add tests for this because we would need to (probably) migrate the existing tests to Playwright (Cypress does not support Safari) and also install multiple browser executables (which would add to our CI run time).
Documentation
N/A
Related Issues
Fixes #36362
[sc-54260]