Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): null check for context #35096

Merged
merged 2 commits into from
Mar 11, 2022
Merged

fix(gatsby): null check for context #35096

merged 2 commits into from
Mar 11, 2022

Conversation

tcoopman
Copy link
Contributor

Description

I've ran into a case where context was undefined resulting in:

TypeError: Cannot read properties of undefined (reading 'telemetryResolverTimings')",
          "    at wrappedTracingResolver (/home/thomas/Workspace/aardling/2022.dddeurope.com/node_modules/gatsby/src/schema/resolvers.ts:679:17)",

there was a check on if (context?.tracer) already but not on the telemtryResolverTimings

Documentation

No updates need
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 10, 2022
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 10, 2022
@LekoArts
Copy link
Contributor

Can you push an empty commit? For some reason the CI didn't trigger a run
@tcoopman
Copy link
Contributor Author

it doesn't look like the windows_unit_tests failing has anything to do with this PR?
@LekoArts LekoArts changed the title null check for context Mar 11, 2022
LekoArts
LekoArts approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@LekoArts LekoArts merged commit 46e2902 into gatsbyjs:master Mar 11, 2022
@saurabharch saurabharch mentioned this pull request Nov 30, 2023
Open
@monizb monizb mentioned this pull request Nov 30, 2023
Open
@saurabharch saurabharch mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
@joeawillis joeawillis mentioned this pull request Nov 30, 2023
Open
@monizb monizb mentioned this pull request Nov 30, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Nov 30, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Nov 30, 2023
Open
@tonyg101 tonyg101 mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
@Rutam21 Rutam21 mentioned this pull request Nov 30, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Nov 30, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Nov 30, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Nov 30, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Nov 30, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Nov 30, 2023
Open
@monizb monizb mentioned this pull request Nov 30, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Nov 30, 2023
Open
@saurabharch saurabharch mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
@kaocher82 kaocher82 mentioned this pull request Dec 1, 2023
Open
@monizb monizb mentioned this pull request Dec 1, 2023
Open
@wizbit wizbit mentioned this pull request Dec 2, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 2, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
This was referenced Dec 2, 2023
Open
Open
Open
This was referenced May 13, 2024
Open
Open
Open
Open
Open
Open
This was referenced May 14, 2024
Open
Open
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
This was referenced May 14, 2024
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
This was referenced May 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
2 participants
@tcoopman @LekoArts