feat(gatsby-source-wordpress): allow path to js file for beforeChangeNode option #32901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
commented
Aug 25, 2021
| beforeChangeNodePath | ||
| ) | ||
| ? beforeChangeNodePath | ||
| : require.resolve( |
There was a problem hiding this comment.
@wardpeet you mentioned gatsby-fs. Is that available now or will this need to be updated in the future?
DanielSLew
reviewed
Aug 25, 2021
DanielSLew
requested changes
Aug 25, 2021
packages/gatsby-source-wordpress/src/steps/declare-plugin-options-schema.js
Show resolved
Hide resolved
DanielSLew
approved these changes
Aug 26, 2021
TylerBarnes
deleted the
feat/wp-allow-fn-path-for-beforechangenode-option
branch
wardpeet
pushed a commit
that referenced
this pull request
Aug 27, 2021
…Node option (#32901) * Allow path to js file for beforeChangeNode option * ensure Joi doesn't fail the build for inline beforeChangeNode fn's * Create gatsby-version.ts * Panic on Gatsby v4+ if beforeChangeNode is a function.
LekoArts
removed
the
status: triage needed
This was referenced Aug 31, 2021
This was referenced May 14, 2024
This was referenced May 14, 2024
This was referenced May 15, 2024
This was referenced May 15, 2024
This was referenced May 15, 2024
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Gatsby v4 functions in plugin options wont work anymore. This change alters the beforeChangeNode plugin type option to allow entering a path to a js file instead.