Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable lmdb by default and update node #32695

Merged
merged 9 commits into from
Aug 27, 2021
Merged

feat: enable lmdb by default and update node #32695

merged 9 commits into from
Aug 27, 2021

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Aug 4, 2021 •
edited
Loading

Description

Created a few patch files that will be run while publishing and testing the next major.

  • Set node to LTS v14
  • Add lmdb as a default package

Related Issues

[ch35493]
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 4, 2021
@wardpeet wardpeet changed the base branch from master to release-cli August 5, 2021 08:17
@wardpeet wardpeet changed the title feat: enable lmdb by default and update lmdb" Aug 5, 2021
@pieh pieh self-assigned this Aug 5, 2021
@wardpeet wardpeet marked this pull request as draft August 5, 2021 10:04
@wardpeet wardpeet added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 5, 2021
pieh
pieh reviewed Aug 5, 2021
View reviewed changes
packages/gatsby/package.json Outdated Show resolved Hide resolved
@wardpeet wardpeet force-pushed the v4/node-14 branch 2 times, most recently from c6affc9 to 6bea214 Compare August 5, 2021 12:44
@wardpeet wardpeet marked this pull request as ready for review August 9, 2021 08:05
Base automatically changed from release-cli to master August 10, 2021 12:21
@wardpeet wardpeet force-pushed the v4/node-14 branch 2 times, most recently from 81e0a55 to 6e2e749 Compare August 12, 2021 16:39
vladar
vladar previously approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump lmdb-store to the latest version at some point (which is 1.6.6 currently). The reason why it is pinned to 1.5.x is that some tests were failing on later versions.

But since we move it out of experimental, we should figure it out. This can be done in a separate PR though, so up to you.
@kariaelo kariaelo mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
This was referenced May 14, 2024
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 14, 2024
Open
@kariaelo kariaelo mentioned this pull request May 14, 2024
Open
This was referenced May 14, 2024
Open
Open
This was referenced May 15, 2024
Open
Open
@kaocher82 kaocher82 mentioned this pull request May 15, 2024
Open
@kariaelo kariaelo mentioned this pull request May 15, 2024
Open
This was referenced May 15, 2024
Open
Open
Open
Open
Open
@Rutam21 Rutam21 mentioned this pull request May 15, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request May 15, 2024
Open
This was referenced May 15, 2024
Open
Open
@Rutam21 Rutam21 mentioned this pull request May 20, 2024
Open
@nidhi42 nidhi42 mentioned this pull request May 20, 2024
Open
This was referenced May 21, 2024
Open
Open
@Rutam21 Rutam21 mentioned this pull request May 21, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 21, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
3 participants
@wardpeet @vladar @pieh