Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-core-utils): Switch auth option from got to username/password #32665

Merged
merged 4 commits into from
Aug 27, 2021
Merged

fix(gatsby-core-utils): Switch auth option from got to username/password #32665

merged 4 commits into from
Aug 27, 2021

Conversation

satrix321
Copy link
Contributor

@satrix321 satrix321 commented Aug 2, 2021 •
edited by LekoArts
Loading

Description

The auth option in got is deprecated, one should use username and password: https://github.com/sindresorhus/got/blob/main/documentation/2-options.md#username

Also there seems to be a Node.js issue with username:password string: sindresorhus/got#1169

Related issues

Fixes #32664
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 2, 2021
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 17, 2021
@LekoArts
Copy link
Contributor

I've also renamed the option since #32791 will also already do this
@LekoArts LekoArts changed the title gatsby-core-utils replace 'auth' param with 'username' and 'password'… Aug 17, 2021
@gatsbyjs gatsbyjs deleted a comment from gatsbot bot Aug 27, 2021
@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 27, 2021
@wardpeet wardpeet merged commit d6326df into gatsbyjs:master Aug 27, 2021
This was referenced Aug 31, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@kariaelo kariaelo mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
This was referenced May 14, 2024
Open
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 14, 2024
Open
@kariaelo kariaelo mentioned this pull request May 14, 2024
Open
This was referenced May 14, 2024
Open
Open
This was referenced May 15, 2024
Open
Open
@kaocher82 kaocher82 mentioned this pull request May 15, 2024
Open
@kariaelo kariaelo mentioned this pull request May 15, 2024
Open
This was referenced May 15, 2024
Open
Open
Open
Open
Open
@Rutam21 Rutam21 mentioned this pull request May 15, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request May 15, 2024
Open
This was referenced May 15, 2024
Open
Open
@Rutam21 Rutam21 mentioned this pull request May 20, 2024
Open
@nidhi42 nidhi42 mentioned this pull request May 20, 2024
Open
This was referenced May 21, 2024
Open
Open
@Rutam21 Rutam21 mentioned this pull request May 21, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 21, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
3 participants
@satrix321 @LekoArts @wardpeet