Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Add dir=ltr to Fast Refresh overlay #29900

Merged
merged 1 commit into from
Mar 2, 2021
Merged

fix(gatsby): Add dir=ltr to Fast Refresh overlay #29900

merged 1 commit into from
Mar 2, 2021

Conversation

herecydev
Copy link
Contributor

Description

Adds a "ltr" direction to prevent issues when working within "rtl" sites. The most problematic fix is the stack trace which gets completely mangled:

Screenshot 2021-03-01 203731
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 1, 2021
@LekoArts LekoArts added topic: hot reloading and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 2, 2021
LekoArts
LekoArts approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, great catch! Thanks for finding this and opening a PR to fix it! 🤗
@LekoArts LekoArts added this to To cherry-pick in Release candidate via automation Mar 2, 2021
@LekoArts LekoArts changed the title Add dir to overlay Mar 2, 2021
@LekoArts LekoArts merged commit 89d3150 into gatsbyjs:master Mar 2, 2021
@gatsbybot gatsbybot mentioned this pull request Mar 2, 2021
Merged
vladar pushed a commit that referenced this pull request Mar 2, 2021
@herecydev @vladar
fix(gatsby): Add dir=ltr to Fast Refresh overlay (#29900)
504b674 
(cherry picked from commit 89d3150)
@vladar vladar moved this from To cherry-pick to Backport PR opened in Release candidate Mar 2, 2021
@herecydev
Copy link
Contributor Author

No problem 🚀
vladar pushed a commit that referenced this pull request Mar 2, 2021
@herecydev
fix(gatsby): Add dir=ltr to Fast Refresh overlay (#29900) (#29908)
df50ce7 
(cherry picked from commit 89d3150)

Co-authored-by: Dan Kirkham <herecy@live.co.uk>
@vladar vladar moved this from Backport PR opened to Backported in Release candidate Mar 2, 2021
@ajesse11x ajesse11x mentioned this pull request Mar 9, 2021
Open
@kaocher82 kaocher82 mentioned this pull request Mar 9, 2021
Open
This was referenced Mar 9, 2021
Open
Open
This was referenced Mar 9, 2021
Open
Open
This was referenced Mar 9, 2021
Open
Open
Open
@ajesse11x ajesse11x mentioned this pull request Mar 9, 2021
Open
This was referenced Mar 9, 2021
Open
Open
@saurabharch saurabharch mentioned this pull request Mar 9, 2021
Open
@kaocher82 kaocher82 mentioned this pull request Mar 9, 2021
Open
@saurabharch saurabharch mentioned this pull request Mar 9, 2021
Open
@ajesse11x ajesse11x mentioned this pull request Mar 9, 2021
Open
@impactyogi impactyogi mentioned this pull request Mar 26, 2024
Open
This was referenced Mar 26, 2024
Open
Open
Open
@Rutam21 Rutam21 mentioned this pull request Mar 27, 2024
Open
This was referenced Mar 27, 2024
Open
Open
@Rutam21 Rutam21 mentioned this pull request Mar 27, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Mar 28, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Apr 14, 2024
Open
@wizbit wizbit mentioned this pull request Apr 14, 2024
Open
@saurabharch saurabharch mentioned this pull request Apr 14, 2024
Open
@monizb monizb mentioned this pull request Apr 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Apr 15, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Apr 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
@monizb monizb mentioned this pull request Apr 29, 2024
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 16, 2024
Open
This was referenced May 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
2 participants
@herecydev @LekoArts