Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Update example sites to build with Gatsby v3 #29899

Merged
merged 2 commits into from
Mar 2, 2021
Merged

fix(gatsby): Update example sites to build with Gatsby v3 #29899

merged 2 commits into from
Mar 2, 2021

Conversation

KyleAMathews
Copy link
Contributor

All of them build except for the WordPress sites which haven't yet been upgraded for the major release of gatsby-source-wordpress.

The following sites emit warnings about upgrading to gatsby-plugin-image:

  • gatsbygram
  • using-mdx
  • using-cypress
  • using-drupal
  • using-gatsby-image
  • using-multiple-themes
  • using-shopify
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 1, 2021
@KyleAMathews @pieh
Update examples/using-shopify/src/components/product.js
1dfe397 
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@KyleAMathews KyleAMathews removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 1, 2021
@LekoArts LekoArts added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Mar 2, 2021
@LekoArts
Copy link
Contributor

LekoArts commented Mar 2, 2021

I've created Clubhouse Story 26215 to track a follow-up update for the examples (as they still need updates!)
@LekoArts LekoArts merged commit e0b324d into master Mar 2, 2021
@LekoArts LekoArts deleted the fix-examples branch March 2, 2021 10:27
@KyleAMathews
Copy link
Contributor Author

thanks @LekoArts !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
3 participants
@KyleAMathews @LekoArts @pieh