fix: drop terminal-link #29472
Merged
fix: drop terminal-link #29472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is weird interaction in some terminals with our usage of terminal-link and ink where following lines turn blank. Let's just remove our usage of terminal-link as value it provides is not worth spending a lot of time on figuring exact reason for this.
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: cli
ascorbic
approved these changes
Feb 12, 2021
ascorbic
pushed a commit
that referenced
this pull request
Feb 12, 2021
There is weird interaction in some terminals with our usage of terminal-link and ink where following lines turn blank. Let's just remove our usage of terminal-link as value it provides is not worth spending a lot of time on figuring exact reason for this. (cherry picked from commit 260c297)
pieh
added a commit
that referenced
this pull request
Feb 12, 2021
There is weird interaction in some terminals with our usage of terminal-link and ink where following lines turn blank. Let's just remove our usage of terminal-link as value it provides is not worth spending a lot of time on figuring exact reason for this. (cherry picked from commit 260c297) Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
|
Published in |
This was referenced Feb 25, 2021
This was referenced May 5, 2021
This was referenced Oct 31, 2022
This was referenced Dec 6, 2023
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is weird interaction in some terminals with our usage of terminal-link and ink where following lines turn blank.
Let's just remove our usage of terminal-link as value it provides is not worth spending a lot of time on figuring exact reason for this.
For details on how problem looks like, check #29293
Note - we do still use
terminal-linkincreate-gatsbyandgatsby-recipes, but it's not clear if it's usage there cause problems or not, so this PR is scoped just togatsbycore packageRelated Issues
Fixes #29293