feat(gatsby): cache/memoize hot functions in runAPI #29240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
topic: scaling builds
and removed
status: triage needed
KyleAMathews
commented
Jan 27, 2021
| const publicPath = getPublicPath({ ...config, ...program }, ``) | ||
|
|
||
| if (typeof publicPath === `undefined`) { | ||
| publicPath = getPublicPath({ ...config, ...program }, ``) |
There was a problem hiding this comment.
skip redundant copying of data
| ...(restrictedActionsAvailableInAPI[api] || {}), | ||
|
|
||
| let availableActions | ||
| if (availableActionsCache.has(api)) { |
There was a problem hiding this comment.
skip redundant copying of data
pieh
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces overhead to invoking APIs by ~40%.
Real-world impact seems around 10-20% for sourcing/transforming data.